run slotscheck explicitly on files#1265
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 79 79
Lines 2434 2434
Branches 211 211
=========================================
Hits 2434 2434 Continue to review full report at Codecov.
|
sobolevn
approved these changes
Feb 2, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Great progress with slotscheck! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
slotscheckwill become more strict about import paths in the future. I'm changing the invocation here to ensureslotscheckruns on the files, not the installed package. Running withpython -mensures the current working directory is insys.pathso the correct files are imported.Checklist
I have created at least one test case for the changes I have maden/aI have updated the documentation for the changes I have maden/aI have added my changes to then/aCHANGELOG.mdRelated issues
#1233